-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Rust vendoring document #66
Conversation
This comment has been minimized.
This comment has been minimized.
5bcea6e
to
156aca9
Compare
CC @liushuyu @schopin-pro @samkamer -- Please let me know if you're fine with this move of the page. |
Is this documentation rendered anywhere? |
Only through GitHub, e.g.: https://github.com/slyon/ubuntu-mir/blob/rust-vendoring/vendoring/Rust.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a quick nit and an open question. Thanks
I believe vendoring directly to For gnome-snapshot, I used the Debian Policy § 4.16 convention of using So the commands to create and update the vendoring are:
Add a patch like this: diff --git a/.cargo/config b/.cargo/config
new file mode 100644
index 0000000..8c56c72
--- /dev/null
+++ b/.cargo/config
@@ -0,0 +1,5 @@
+[source.crates-io]
+replace-with = "debian"
+
+[source.debian]
+directory = "debian/missing-sources" |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Maybe we can take a page from Node.js, where you can have another source package |
@liushuyu I really like this approach. Could you provide an example of such a Rust package and describe how it's being done? A similar approach of a vendoring .orig tarball has also been suggested by others in the past, e.g.: https://blog.shadura.me/2020/12/22/vendoring-rust-in-debian-derivative/ |
156aca9
to
c3b68f7
Compare
This comment has been minimized.
This comment has been minimized.
0f66db9
to
149b433
Compare
s390-tools uses that approach.
…On Tue, 17 Sept 2024, 12:08 Lukas Märdian, ***@***.***> wrote:
Maybe we can take a page from Node.js, where you can have another source
package <name>.orig-vendor.tar.xz. Some other Rust packages are doing
this way instead.
@liushuyu <https://github.com/liushuyu> I really like this approach.
Could you provide an example of such a Rust package and describe how it's
being done?
—
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUXZP7I2NAPT3U2WSA446L3ZW75SJAVCNFSM6AAAAABNR2CPJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJVGE3DKOJRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This comment has been minimized.
This comment has been minimized.
8cde2e6
to
adda2c5
Compare
This comment has been minimized.
This comment has been minimized.
As used by the s390-tools package and suggested by the Rust toolchain team.
check-spelling run (pull_request_target) for rust-vendoring Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
I've added an example of how This PR should now be ready for merging if others agree! |
Importing the "RustCodeInMain" wiki page and transforming it to Markdown: https://wiki.ubuntu.com/RustCodeInMain
Also updating the README.md file to reference the documentation around the
dh-cargo
tooling.Fixes #65